-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnusedDeclaration and UnusedCall linters #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 208
💛 - Coveralls |
Pull Request Test Coverage Report for Build 216
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnusedDeclaration: a (non-output) value is declared, but not subsequently used in the task/workflow.
UnusedCall: the outputs of a call within a workflow are neither outputs from the workflow, nor used by anything else in the workflow.
In the process of developing these, we realized that the task commands in many draft-2 WDLs were not being parsed as expected (specifically,
${ }
delimited placeholders were ignored within<<< >>>
delimited commands, which are indeed not recognized as placeholders in WDL 1.0). To address this, we introduce a rudimentary way to serve different grammar versions, and detect the version from the document header, if any. The mechanism will need more polishing.Typecheck task runtime section.
Fix several bugs and omissions in the AST, Walker, etc.