Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework struct initialization from read_json() #525

Merged
merged 10 commits into from
Nov 23, 2021

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 15, 2021

Initializing a struct from unsafe read_json(), change the transient intermediate codepath to go through Object instead of Map, avoiding various problems caused by spurious attempt to unify heterogeneous value types. Improve error messages.

mostly addresses #524

@coveralls
Copy link

coveralls commented Nov 16, 2021

Pull Request Test Coverage Report for Build 1479461576

  • 72 of 74 (97.3%) changed or added relevant lines in 3 files are covered.
  • 109 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-1.4%) to 95.064%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Type.py 2 3 66.67%
WDL/Value.py 60 61 98.36%
Files with Coverage Reduction New Missed Lines %
WDL/runtime/task.py 1 95.24%
WDL/runtime/workflow.py 1 97.21%
WDL/init.py 3 93.2%
WDL/runtime/error.py 4 93.33%
WDL/Value.py 4 98.02%
WDL/runtime/task_container.py 7 93.37%
WDL/Error.py 8 89.94%
WDL/Type.py 8 94.91%
WDL/Expr.py 23 94.02%
WDL/Tree.py 50 93.53%
Totals Coverage Status
Change from base Build 1432387464: -1.4%
Covered Lines: 6818
Relevant Lines: 7172

💛 - Coveralls

@mlin
Copy link
Collaborator Author

mlin commented Nov 16, 2021

Coveralls seems to be counting ALL docstrings as newly uncovered 👎

@mlin mlin marked this pull request as ready for review November 16, 2021 22:16
@mlin
Copy link
Collaborator Author

mlin commented Nov 23, 2021

Initializing a struct from unsafe read_json(), change the transient intermediate representation to Object instead of Map, avoiding spurious attempts to unify heterogeneous value types. Improve error messages.

addresses most of #524 @jlumpe

@mlin mlin merged commit 8adb212 into main Nov 23, 2021
@mlin mlin deleted the mlin/rework-struct-from-read-json branch November 23, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants