Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten optional-to-String coercions #600

Merged
merged 4 commits into from
Jan 28, 2023
Merged

tighten optional-to-String coercions #600

merged 4 commits into from
Jan 28, 2023

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Sep 12, 2022 •
edited
Loading

#596

As this is a potentially-breaking change we will take some time to merge/release it, with deprecation linter warnings in the meantime (#602).

@coveralls
Copy link

coveralls commented Sep 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4030769228

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 95.205%
Files with Coverage Reduction New Missed Lines %
WDL/Lint.py 1 98.54%
Totals Coverage Status
Change from base Build 3935310202: 0.008%
Covered Lines: 7267
Relevant Lines: 7633
💛 - Coveralls

@mlin mlin marked this pull request as ready for review January 28, 2023 07:30
@mlin mlin merged commit 9135bd3 into main Jan 28, 2023
@mlin mlin deleted the mlin/optional-to-string-coercions branch January 28, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlin @coveralls