Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_json() stub and Any type #64

Merged
merged 2 commits into from
Dec 21, 2018
Merged

read_json() stub and Any type #64

merged 2 commits into from
Dec 21, 2018

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Dec 21, 2018

read_json() can return values of different types depending on what's in the JSON file at runtime. Introduce WDL.Type.Any to model this, and use it instead of None to represent the item types of empty Array/Map literals.

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 313

  • 23 of 32 (71.88%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 95.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Type.py 17 19 89.47%
WDL/StdLib.py 2 9 22.22%
Files with Coverage Reduction New Missed Lines %
WDL/Type.py 2 95.93%
Totals Coverage Status
Change from base Build 307: 0.04%
Covered Lines: 2122
Relevant Lines: 2231

💛 - Coveralls

@mckinsel
Copy link
Contributor

IIRC, we ran into some funky wdl4s limitations with read_json for the HCA. See here for the discussion. Not sure how the deprecation of Object affects this.

@mlin
Copy link
Collaborator Author

mlin commented Dec 21, 2018

@mckinsel thanks for the heads up -- right now we're just at the stage of stubbing out function signatures, so we'll need to come back to this, now that the spec is +Struct and -Object!

@mlin mlin merged commit abc5183 into master Dec 21, 2018
@mlin mlin deleted the mlin-read-json branch February 15, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants