Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework effective_outputs #77

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Rework effective_outputs #77

merged 3 commits into from
Feb 4, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Feb 4, 2019

  • Make them Env.Types instead of Env.Decls
  • Correctly type the outputs of calls inside scatter and conditional sections
  • Clean up internals using new Env.map

@mlin
Rework effective_outputs
f1bb945 
- Make them Env.Types instead of Env.Decls
- Correctly type the outputs of calls inside scatter and conditional sections
- Clean up internals using new Env.map
@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 382

  • 42 of 42 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 95.134%
Totals Coverage Status
Change from base Build 360: 0.09%
Covered Lines: 2268
Relevant Lines: 2384
💛 - Coveralls

@mlin mlin merged commit 2b46030 into master Feb 4, 2019
@mlin mlin deleted the mlin-rework-effective-outputs branch February 15, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlin @coveralls