Return 404 for plugins that don't exist (#1226)

chanzuckerberg · Aug 18, 2023 · 3f42706 · 3f42706
1 parent d49be77
commit 3f42706
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/backend/api/app.py b/backend/api/app.py
@@ -84,7 +84,10 @@ def plugins() -> Response:
 @app.route("/plugins/<plugin>", defaults={"version": None})
 @app.route("/plugins/<plugin>/versions/<version>")
 def versioned_plugin(plugin: str, version: str = None) -> Response:
-    return jsonify(plugin_model.get_plugin(plugin, version))
+    plugin = plugin_model.get_plugin(plugin, version)
+    if not plugin:
+        return app.make_response(("Plugin does not exist", 404))
+    return jsonify(plugin)
 
 
 @app.route("/plugin/home/sections/<sections>")