Adding exception logging (#1194)

chanzuckerberg · Aug 2, 2023 · 81a7235 · 81a7235
1 parent b475b43
commit 81a7235
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/backend/api/app.py b/backend/api/app.py
@@ -191,11 +191,13 @@ def handle_exception(e) -> Response:
 
 @app.errorhandler(exceptions.Unauthorized)
 def handle_permission_exception(e) -> Response:
+    logger.error(f"Unauthorized Access to endpoint {request.method} {request.endpoint}")
     return app.make_response(("Unauthorized Access", 401))
 
 
 @app.errorhandler(Exception)
 def handle_exception(e) -> Response:
+    logger.error(f"An unexpected error has occurred in napari hub: {e}", e)
     send_alert(f"An unexpected error has occurred in napari hub: {e}")
     return app.make_response(("Internal Server Error", 500))
 

diff --git a/backend/api/metrics.py b/backend/api/metrics.py
@@ -52,7 +52,7 @@ def _get_usage_data(name: str, limit: int) -> Dict[str, Any]:
     }
 
 
-def _get_maintenance_data(name: str, repo: Any, limit: int) -> Dict[str, Any]:
+def _get_maintenance_data(name: str, repo: Optional[str], limit: int) -> Dict[str, Any]:
     """
     Fetches plugin maintenance_data from dynamo.
     :returns Dict[str, Any]: A dict with entries for timeline and stats.