Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection font sizes #1003

Merged
merged 7 commits into from
May 5, 2023
Merged

Conversation

codemonkey800
Copy link
Collaborator

@codemonkey800 codemonkey800 commented Apr 28, 2023

Description

#932

Updates font sizes based on design updates to improve Lighthouse SEO scores for the collection page.

@codemonkey800 codemonkey800 added the improvement Release Label: Used for categorizing improvements in automated CI release notes label Apr 28, 2023
@codemonkey800 codemonkey800 marked this pull request as ready for review May 2, 2023 16:06
@codemonkey800
Copy link
Collaborator Author

@Janeece I'll work on getting a test deployment for you soon, we're currently having issues with the workflow for some reason 😢

image

@codemonkey800
Copy link
Collaborator Author

@Janeece deployment should be ready: https://dev-font-size-frontend.dev.imaging.cziscience.com/collections

Copy link

@Janeece Janeece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @codemonkey800

@codemonkey800 codemonkey800 merged commit fc29ca7 into main May 5, 2023
@codemonkey800 codemonkey800 deleted the jeremy/collection-font-sizes branch May 5, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Release Label: Used for categorizing improvements in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants