Create plugin dynamo tables #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klai95
previously approved these changes
Mar 30, 2023
codemonkey800
previously approved these changes
Mar 30, 2023
manasaV3
force-pushed
the
plugin-db-infra
branch
from
0505f4e
to
7296a3b
Compare
richaagarwal
previously approved these changes
Apr 6, 2023
codemonkey800
previously approved these changes
Apr 6, 2023
klai95
previously approved these changes
Apr 7, 2023
codemonkey800
added
the
new-feature
manasaV3
dismissed stale reviews from klai95, codemonkey800, and richaagarwal
via
f454243
codemonkey800
previously approved these changes
May 8, 2023
| }, | ||
| { | ||
| name = "is_latest" | ||
| type = "S" #terraform only supports String, Number or Binary for primary key attribute |
There was a problem hiding this comment.
how are we planning on storing this? something like true or false?
There was a problem hiding this comment.
Yeah, they will be treated as strings with the value "true" or "false".
The data type now unfortunately becomes a part of the business logic.
codemonkey800
approved these changes
May 8, 2023
klai95
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #880
Description
Creates tables for
plugin,plugin-metadataandplugin-blocked.The
plugin-blockedschema follows the spec from the RFC.The
plugin-metadatatable will store the data from different sources such as pypi, github and manifest. The table will follow the schema designed for the plugin table but without the secondary indices. As the records will only have the source data, the attributes in this table will also be only those defined for the source data ie name, version-type, version, type, data, last_updated_timestampThe
plugintable will store only the aggregated plugin data. The schema follows the spec from the RFC with the change that the range key is now the version of the plugin. Thetypeidentifier is no longer needed, as all the records in this table are oftype=AGGREGATE. This will also result in the type attribute not being stored in this table.