Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep linking #60

Merged
merged 12 commits into from
Apr 19, 2022
Merged

deep linking #60

merged 12 commits into from
Apr 19, 2022

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Apr 19, 2022 •
edited

Move ontology explorer state into the URL and refactor a bunch of state.

Changes:

  • moved into browser URL state: pinned vertex, intra-ontology search term, sub tree root ID
  • changing linking in Vertex to take advantage of the new URL state management
  • added new effect debugger code (only present in non-production build)
  • memoized dag creation
  • Generalized "compartment" search to be "cross reference search"; button label change
  • Add "Deselect" button to ontology explorer - unpins the pinned vertex
  • Vertex ancestor and descendant links now select in graph.

Fixes #38
Fixes #37
Fixes #25

@bkmartinjr bkmartinjr marked this pull request as ready for review April 19, 2022 18:57
@bkmartinjr bkmartinjr merged commit eb949a2 into main Apr 19, 2022
@bkmartinjr bkmartinjr deleted the bkmartinjr/deep-linking branch April 19, 2022 21:32
@bkmartinjr bkmartinjr mentioned this pull request Apr 19, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmegill colinmegill colinmegill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OntologyUI
Status: No status
Milestone
No milestone
2 participants
@bkmartinjr @colinmegill