[change] Drop support for depends_on ActiveRecord model #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldong
changed the base branch from
main
to
base/donaldong/change_drop_suppordbce1db
donaldong
added a commit
that referenced
this pull request
Feb 17, 2021
Pull Request Branch: donaldong/change_drop_support_for2a4f3a8 Pull Request Link: #43
donaldong
force-pushed
the
donaldong/change_drop_support_for2a4f3a8
branch
from
50d2aec
to
f0cfea3
Compare
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 97.10% 97.05% -0.06%
==========================================
Files 32 32
Lines 1934 1933 -1
==========================================
- Hits 1878 1876 -2
- Misses 56 57 +1
Continue to review full report at Codecov.
|
donaldong
changed the title
katyho
reviewed
Feb 17, 2021
Comment on lines
35
to
36
| memo = model.redis_memo_class_memoizable | ||
| nodes[memo.cache_key] = memo |
There was a problem hiding this comment.
I think we can move this out of the inner loop?
There was a problem hiding this comment.
Ah, that is true!
donaldong
added a commit
that referenced
this pull request
Feb 17, 2021
Pull Request Branch: donaldong/change_drop_support_for2a4f3a8 Pull Request Link: #43
|
move class memo out of the inner loop |
donaldong
added a commit
that referenced
this pull request
Feb 17, 2021
Pull Request Branch: donaldong/change_drop_support_for2a4f3a8 Pull Request Link: #43
donaldong
force-pushed
the
donaldong/change_drop_support_for2a4f3a8
branch
from
f0cfea3
to
8363bba
Compare
katyho
approved these changes
Feb 17, 2021
Pull Request Branch: donaldong/change_drop_support_for2a4f3a8 Pull Request Link: #43
donaldong
changed the base branch from
base/donaldong/change_drop_suppordbce1db
to
main
donaldong
force-pushed
the
donaldong/change_drop_support_for2a4f3a8
branch
from
8363bba
to
cd1f807
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This marks
depends_on Model, **attrsas a private API. Users can no longer set dependencies on some queries without callingextract_bind_params.Test Plan