[bug fix] Drop support for JOIN queries #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldong
changed the base branch from
main
to
base/donaldong/drop_support_for_j0dc6a22
donaldong
added a commit
that referenced
this pull request
Feb 1, 2021
Pull Request Branch: donaldong/drop_support_for_join_queries Pull Request Link: #6 Pull Request Stack: donaldong/beta-1
donaldong
force-pushed
the
donaldong/drop_support_for_join_queries
branch
from
732060f
to
52f74c7
Compare
katyho
approved these changes
Feb 1, 2021
katyho
reviewed
Feb 1, 2021
| teacher = Teacher.create! | ||
| expect_to_use_redis do | ||
| expect_not_to_use_redis do |
There was a problem hiding this comment.
Technically we can support this query though right? What's an example join query that wouldn't be supported well, as long as we have this change to make sure that a filtering condition exists on the table we're selecting?
There was a problem hiding this comment.
Great question! Currently, it's possible to select columns from a table that does not have any filtering conditions:
SELECT "teacher_id" FROM "sites" INNER JOIN "teacher_sites" ON "sites"."id" = "teacher_sites"."site_id" WHERE "sites"."id" IN (...)this query should be invalidated when teacher_sites records have changed
Pull Request Branch: donaldong/drop_support_for_join_queries Pull Request Link: #6 Pull Request Stack: donaldong/beta-1
donaldong
changed the base branch from
base/donaldong/drop_support_for_j0dc6a22
to
main
donaldong
force-pushed
the
donaldong/drop_support_for_join_queries
branch
from
52f74c7
to
db1e4f3
Compare
donaldong
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't really support JOINs well. Currently, it's still possible to have stale cache results if we are selecting from joined tables that do not filter conditions.
This drops the support for JON queries and we can revisit this later.
Test Plan
📚 Related Pull Requests 📚