-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #4488 - Added sharding E2E tests in the CI #4489
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4489 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 171 171
Lines 12543 12543
=======================================
Hits 10756 10756
Misses 1787 1787
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@charles-testco quick feedback -- in PR description we can drop prefix E.g., Thank you 👍 |
The sharding is amazing! Thanks so much for adding it 🙏 And feels like we might be able to drop Thanks again! |
Yes, we can remove them |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for speeding things up!
f8d177c
to
54d6d6d
Compare
I am closing this PR and raise a new one as suggested by some people to resolve the stale status: e2e-test Expected — Waiting for status to be reported |
Reason for Change
Shard E2E tests in the CI #4488
added project matrix strategy so each browser is executed on a separate runner so that they run in parallel