Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4488 - Added sharding E2E tests in the CI #4489

Closed
wants to merge 27 commits into from

Conversation

charles-testco
Copy link
Contributor

@charles-testco charles-testco commented Apr 5, 2023

Reason for Change

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4489 (e43ff75) into main (121fb16) will not change coverage.
The diff coverage is n/a.

❗ Current head e43ff75 differs from pull request most recent head 9f0438c. Consider uploading reports for the commit 9f0438c to get more accurate results

@@           Coverage Diff           @@
##             main    #4489   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         171      171           
  Lines       12543    12543           
=======================================
  Hits        10756    10756           
  Misses       1787     1787           
Flag Coverage Δ
unittests 85.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tihuan
Copy link
Contributor

tihuan commented Apr 5, 2023

@charles-testco quick feedback -- in PR description we can drop prefix ZEN and just use #NNNN to directly link to the Github issue!

E.g., #4488 instead of #ZEN-4488

Thank you 👍

@charles-testco charles-testco changed the title feat: [ZEN-4488] - Added sharding E2E tests in the CI feat: #4488 - Added sharding E2E tests in the CI Apr 6, 2023
@tihuan
Copy link
Contributor

tihuan commented Apr 6, 2023

The sharding is amazing! Thanks so much for adding it 🙏

And feels like we might be able to drop e2e-all and other related script commands, since it still uses the same amount of workers anyway?

Thanks again!

@charles-testco
Copy link
Contributor Author

The sharding is amazing! Thanks so much for adding it 🙏

And feels like we might be able to drop e2e-all and other related script commands, since it still uses the same amount of workers anyway?

Thanks again!

Yes, we can remove them

@charles-testco
Copy link
Contributor Author

The sharding is amazing! Thanks so much for adding it 🙏

And feels like we might be able to drop e2e-all and other related script commands, since it still uses the same amount of workers anyway?

Thanks again!

done

frontend/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ashin-czi ashin-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for speeding things up!

@charles-testco charles-testco force-pushed the charles/zen-4488/shard-e2e-tests branch from f8d177c to 54d6d6d Compare April 13, 2023 16:32
@charles-testco
Copy link
Contributor Author

I am closing this PR and raise a new one as suggested by some people to resolve the stale status:

e2e-test Expected — Waiting for status to be reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants