Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep unsupported union values as-is #53

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Keep unsupported union values as-is #53

merged 1 commit into from
Jun 2, 2021

Conversation

datbth
Copy link
Contributor

@datbth datbth commented Jun 2, 2021

Summary

  • Keep unsupported union values as-is, instead of raising error. Let sorbet itself raise error if the value does not fit into the union type.

Description

I believe this behavior makes it more convenient to deal with union types when coercing.

@datbth
keep unsupported union values as-is
9155ce7 
instead of raising error
donaldong
donaldong approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@donaldong donaldong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes sense to me.

Thanks for contributing!

@donaldong donaldong merged commit e59c635 into chanzuckerberg:master Jun 2, 2021
@mattxwang mattxwang mentioned this pull request Aug 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldong donaldong donaldong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@datbth @donaldong