Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle T.class_of and unknown types #56

Merged
merged 2 commits into from
May 12, 2022
Merged

Handle T.class_of and unknown types #56

merged 2 commits into from
May 12, 2022

Conversation

datbth
Copy link
Contributor

@datbth datbth commented Sep 22, 2021 •
edited

Summary

Currently, using TypeCoerce on T.class_of raises an uncaught exception:
image
(see example in the new spec)

This PR tries to:

  • Keep values as-is when dealing with T.class_of types
  • Improve the handling of unknown types

@datbth datbth changed the title keep T.class_of values as-is Keep values as-is when dealing with unknown types Sep 22, 2021
@datbth datbth changed the title Keep values as-is when dealing with unknown types Handle T.class_of and unknown types Sep 22, 2021
donaldong
donaldong approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@donaldong donaldong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks for the PR!

@katyho katyho merged commit 6ce2638 into chanzuckerberg:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyho katyho katyho approved these changes

@donaldong donaldong donaldong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@datbth @katyho @donaldong