Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves Ruby version support window to ['2.7', '3.0', '3.1'] #69

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

mattxwang
Copy link
Contributor

@mattxwang mattxwang commented Jul 27, 2022

Ruby 2.4, 2.5, and 2.6 are all EOL! And, since Donald was last involved in this gem, Ruby 3 and 3.1 have been stabilized.

This PR:

  • updates our CI to require checks to pass for ['2.7', '3.0', '3.1'] (note that ruby-head is still allowed to fail)
  • bumps the gemspec's required ruby version
  • deletes the old Travis config

@mattxwang mattxwang marked this pull request as ready for review July 27, 2022 00:05
@mattxwang mattxwang marked this pull request as draft July 27, 2022 00:05
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #69 (35b38f5) into main (f6f6659) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   99.26%   99.25%   -0.01%     
==========================================
  Files           6        6              
  Lines         407      403       -4     
==========================================
- Hits          404      400       -4     
  Misses          3        3              
Impacted Files Coverage Δ
lib/sorbet-coerce/converter.rb 97.36% <0.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@mattxwang
Copy link
Contributor Author

Going to be honest, don't understand why the codecov check is failing - the impacted file shows nothing!

@mattxwang mattxwang marked this pull request as ready for review July 27, 2022 00:10
@mattxwang mattxwang requested review from shitchcock and a team July 27, 2022 00:10
@mattxwang mattxwang merged commit 20fe622 into main Aug 10, 2022
@mattxwang mattxwang deleted the mwang/drop-eol-ruby-support branch August 10, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants