Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates bundled-rbi with new coerce_empty_to_nil argument #70

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

mattxwang
Copy link
Contributor

Realised that we never updated the bundled RBI with the new option passed to .from. This PR fixes that!

See also: sorbet/sorbet-typed#396

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@beefa45). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5832184 differs from pull request most recent head 7b2e3b2. Consider uploading reports for the commit 7b2e3b2 to get more accurate results

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   99.26%           
=======================================
  Files           ?        6           
  Lines           ?      409           
  Branches        ?        0           
=======================================
  Hits            ?      406           
  Misses          ?        3           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattxwang mattxwang requested a review from a team July 28, 2022 19:49
@mattxwang mattxwang merged commit afa640a into main Aug 11, 2022
@mattxwang mattxwang deleted the mwang/update-bundled-rbi branch August 11, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants