This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Integer/Float attributes accept many different types #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 96.14% 96.14% +<.01%
==========================================
Files 138 138
Lines 2228 2233 +5
==========================================
+ Hits 2142 2147 +5
Misses 86 86
Continue to review full report at Codecov.
|
ghiculescu
force-pushed
the
integer_type_more_options
branch
from
3f087b0
to
bcefcbc
Compare
Currently we are quite strict about what types can be passed to an attribute of type `Integer`/`Float`, but in reality Rails is quite accommodating. This PR allows more types to be passed in. Fixes sorbet/sorbet-typed#163 (comment)
ghiculescu
force-pushed
the
integer_type_more_options
branch
from
bcefcbc
to
16a8027
Compare
hdoan741
reviewed
Nov 12, 2019
| @@ -131,15 +131,23 @@ def time_zone_aware_column?(column_def, cast_type) | |||
|
|
|||
| sig { params(column_type: Object).returns(String) } | |||
| def value_type_for_attr_writer(column_type) | |||
There was a problem hiding this comment.
We probably should pass a column_def to this method and have a switcher based on active_record_type like active_record_type_to_sorbet_type
|
Created an issue for code quality improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are quite strict about what types can be passed to an attribute of type
Integer/Float, but in reality Rails is quite accommodating. This PR allows more types to be passed in.Fixes sorbet/sorbet-typed#163 (comment)