This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
fix spec failures in rails 6 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hdoan741
commented
May 10, 2020
•
hdoan741
commented
- The build/create/create!/new method on ActiveRecord Relation now use a new sig
- Force generating named scope methods in Rails 6
- Fix sig with active_storage: attachables shouldn't have *
- Regenerate routes.rbi for Rails 6.
- Disable test for Ruby 2.7, Rails 6 due to a RBI generation error: Bug generating RBI for Rails 6.0.3, Ruby 2.7 sorbet/sorbet#2994
hdoan741
pushed a commit
that referenced
this pull request
May 10, 2020
- The build/create/create!/new method on ActiveRecord Relation now use a new sig - Force generating named scope methods in Rails 6 - Fix sig with active_storage: attachables shouldn't have * Pull Request Branch: manhhung741/fix_spec Pull Request Link: #329
hdoan741
force-pushed
the
manhhung741/fix_spec
branch
from
e4ba63a
to
cfddcee
Compare
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 97.20% 97.36% +0.15%
==========================================
Files 155 155
Lines 3331 3334 +3
==========================================
+ Hits 3238 3246 +8
+ Misses 93 88 -5
Continue to review full report at Codecov.
|
- The build/create/create!/new method on ActiveRecord Relation now use a new sig - Force generating named scope methods in Rails 6 - Fix sig with active_storage: attachables shouldn't have * Pull Request Branch: manhhung741/fix_spec Pull Request Link: #329
hdoan741
force-pushed
the
manhhung741/fix_spec
branch
from
cfddcee
to
5138776
Compare
|
disable 2.7 for rails 6.0 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.