Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

fix spec failures in rails 6 #329

Merged
merged 1 commit into from
May 10, 2020
Merged

fix spec failures in rails 6 #329

merged 1 commit into from
May 10, 2020

Conversation

hdoan741
Copy link
Contributor

@hdoan741 hdoan741 commented May 10, 2020

  • The build/create/create!/new method on ActiveRecord Relation now use a new sig
  • Force generating named scope methods in Rails 6
  • Fix sig with active_storage: attachables shouldn't have *
  • Regenerate routes.rbi for Rails 6.
  • Disable test for Ruby 2.7, Rails 6 due to a RBI generation error: Bug generating RBI for Rails 6.0.3, Ruby 2.7 sorbet/sorbet#2994

hdoan741 pushed a commit that referenced this pull request May 10, 2020
- The build/create/create!/new method on ActiveRecord Relation now use a new sig
- Force generating named scope methods in Rails 6
- Fix sig with active_storage: attachables shouldn't have *

Pull Request Branch: manhhung741/fix_spec
Pull Request Link: #329
@codecov-io
Copy link

codecov-io commented May 10, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   97.20%   97.36%   +0.15%     
==========================================
  Files         155      155              
  Lines        3331     3334       +3     
==========================================
+ Hits         3238     3246       +8     
+ Misses         93       88       -5     
Impacted Files Coverage Δ
...rbet-rails/model_plugins/active_storage_methods.rb 100.00% <ø> (ø)
lib/sorbet-rails/active_record_rbi_formatter.rb 100.00% <100.00%> (ø)
lib/sorbet-rails/model_utils.rb 98.38% <100.00%> (ø)
spec/sorbet_spec.rb 100.00% <0.00%> (+13.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb20a39...5138776. Read the comment docs.

- The build/create/create!/new method on ActiveRecord Relation now use a new sig
- Force generating named scope methods in Rails 6
- Fix sig with active_storage: attachables shouldn't have *

Pull Request Branch: manhhung741/fix_spec
Pull Request Link: #329
@hdoan741
Copy link
Contributor Author

disable 2.7 for rails 6.0

🔎 Click to see changes since last update.

@hdoan741 hdoan741 merged commit 6285cd7 into master May 10, 2020
@hdoan741 hdoan741 deleted the manhhung741/fix_spec branch May 10, 2020 04:53
@connorshea
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants