fix: Allow empty result when looking for storage integration on refre…

…sh (#692)

pkg/resources/storage_integration.go

@@ -170,6 +170,12 @@ func ReadStorageIntegration(d *schema.ResourceData, meta interface{}) error {
 	// Some properties can come from the SHOW INTEGRATION call
 
 	s, err := snowflake.ScanStorageIntegration(row)
+	if err == sql.ErrNoRows {
+		// If not found, mark resource to be removed from statefile during apply or refresh
+		log.Printf("[DEBUG] storage integration (%s) not found", d.Id())
+		d.SetId("")
+		return nil
+	}
 	if err != nil {
 		return fmt.Errorf("Could not show storage integration: %w", err)
 	}

pkg/resources/storage_integration_test.go

@@ -56,6 +56,19 @@ func TestStorageIntegrationRead(t *testing.T) {
 	})
 }
 
+func TestStorageIntegrationReadEmpty(t *testing.T) {
+	r := require.New(t)
+
+	d := storageIntegration(t, "test_storage_integration", map[string]interface{}{"name": "not_existing_storage_integration"})
+
+	WithMockDb(t, func(db *sql.DB, mock sqlmock.Sqlmock) {
+		expectReadStorageIntegrationEmpty(mock)
+
+		err := resources.ReadStorageIntegration(d, db)
+		r.Nil(err)
+  })
+}
+
 func TestStorageIntegrationUpdate(t *testing.T) {
 	r := require.New(t)
 
@@ -134,3 +147,10 @@ func expectReadStorageIntegrationForGCS(mock sqlmock.Sqlmock) {
 
 	mock.ExpectQuery(`DESCRIBE STORAGE INTEGRATION "test_storage_integration"$`).WillReturnRows(descRows)
 }
+
+func expectReadStorageIntegrationEmpty(mock sqlmock.Sqlmock) {
+	noRows := sqlmock.NewRows([]string{
+		"name", "type", "category", "enabled", "created_on"},
+	)
+	mock.ExpectQuery(`^SHOW STORAGE INTEGRATIONS.*`).WillReturnRows(noRows)
+}