Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alerts): phase2 bugs #1010

Merged
merged 3 commits into from
Jun 29, 2022
Merged

fix(alerts): phase2 bugs #1010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd7d3e7
fix(alerts): format errors
Amatullah Jun 28, 2022
8a422a3
fix(alerts): link to dashboard with subdims shown if subdims enabled
Samyak2 Jun 28, 2022
542aabc
fix(docker): serve flask static files correctly
Samyak2 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chaos_genius/alerts/email_templates/common.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
-->{% if point.relevant_subdims is not none -%}
<ul>
<li>
<span style="{{ non_important_text }}">Key dimensions impacted:</span>
<span style="{{ non_important_text }}">Reasons for change:</span>
{% for point in point.top_relevant_subdims() %}
{{ subdim_name_link(point, value_only=true) }}<!--
-->{% if not loop.last -%}
Expand Down
5 changes: 3 additions & 2 deletions chaos_genius/alerts/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def anomaly_point_formatting(
else:
out += " detected "
if point.is_subdim:
out += f" in {subdim_name_link(point)} "
out += f"in {subdim_name_link(point)} "

if point.previous_value is None:
out += f"- changed to *{point.y_readable}*"
Expand Down Expand Up @@ -318,7 +318,7 @@ def anomaly_point_formatting(
else:
out += " detected "
if point.is_subdim:
out += f" in {subdim_name_link(point)} "
out += f"in {subdim_name_link(point)} "

out += f"- changed to *{point.y_readable}*"

Expand All @@ -335,6 +335,7 @@ def anomaly_point_formatting(
out += "\n - Reasons for change: "
for point in point.top_relevant_subdims() or []:
out += f"{subdim_name_link(point, value_only=True)}, "
out = out[:-2]

out += "\n"

Expand Down