Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ENV variable, non-json log messages for development #1059

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kartikay-bagla
Copy link
Contributor

No description provided.

@gitguardian
Copy link

gitguardian bot commented Jul 25, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2745890 Generic High Entropy Secret ac8325f .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2022

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit ac8325f
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62de56d9a0ee3c0009455682
😎 Deploy Preview https://deploy-preview-1059--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@manassolanki manassolanki added the don't merge PR which doesn't need to be merged right now label Jul 25, 2022
@Samyak2
Copy link
Contributor

Samyak2 commented Sep 6, 2022

FLASK_ENV is deprecated in Flask 2.2:

The FLASK_ENV environment variable and app.env attribute are deprecated, removing the distinction between development and debug mode. Debug mode should be controlled directly using the --debug option or app.run(debug=True).

https://github.com/pallets/flask/blob/main/CHANGES.rst#version-220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge PR which doesn't need to be merged right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants