fix(anomaly): ensure correct data types #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty prediction dataframe is now given the correct types immediately after creation. This ensures that any data appended to the dataframe will have the correct type. Note: if the columns or the dataframe itself is overwritten, this will not hold and the types may change. Also uses a simpler method to get the last row of the prediction dataframe which prevents loss of types. The earlier version would erase all the metadata and make the dtypes `object`. These 2 changes ensure that the `y` column is always a `float` and the dataframe correctly identifies it as such. Note: the columns can still be overriden by some other code and this cannot be ensured without writing tests.
|
|
✅ Deploy Preview for frontend-sb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Samyak2
requested review from
manassolanki and
Amatullah
and removed request for
kartikay-bagla
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The empty prediction dataframe is now given the correct types immediately after creation. This ensures that any data appended to the dataframe will have the correct type. Note: if the columns or the dataframe itself is overwritten, this will not hold and the types may change.
Also uses a simpler method to get the last row of the prediction dataframe which prevents loss of types. The earlier version would erase all the metadata and make the dtypes
object.These 2 changes ensure that the
ycolumn is always afloatand the dataframe correctly identifies it as such. Note: the columns can still be overriden by some other code and this cannot be ensured without writing tests.TODO