Observable tasks deepdrills #446
Conversation
|
✔️ Deploy Preview for frontend-sb canceled. 🔨 Explore the source changes: af5f0c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/61a5dcf02a20ed00070bfcaa |
There was a problem hiding this comment.
We should refrain from misspells or obsolete spells like computor for sub tasks. It’s okay for now as the sub tasks would be iterated with @pshrimal21
| self._checkpoint_failure("Data Loader", e) | ||
| self._checkpoint_success("Data Loader") |
There was a problem hiding this comment.
These are specific to a timeline, right? We should add timeline name to the message as in aggregation and computation.
| @@ -332,25 +339,35 @@ def compute(self): | |||
| try: | |||
| rca_data = self._get_rca(rca, dim, timeline) | |||
| output.append(self._output_to_row("rca", rca_data, timeline, dim)) | |||
| except: # noqa E722 | |||
| self._checkpoint_success("Base DeepDrills Calculator") | |||
There was a problem hiding this comment.
This one is specific to a dimension and a timeline. Should be added to the message, otherwise we'll see many instances of "Base DeepDrills calculator" repeated.
There was a problem hiding this comment.
Yes, I think almost everything in RCA is timeline dependent
| self._checkpoint_failure("Htable Calculator", e) | ||
| # TODO: Checkpoint failure for htable calculation here. | ||
| self._checkpoint_success("Htable Calculator") |
There was a problem hiding this comment.
This too is specific to a timeline.
There was a problem hiding this comment.
For now, it should be fine because the entries above it will have the timeline.
Added status messages for various steps in DeepDrills