Add the data index #461
Merged
Add the data index #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for frontend-sb ready! 🔨 Explore the source changes: 5415f72 🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/61a8a6a27737a90007b515c9 😎 Browse the preview: https://deploy-preview-461--frontend-sb.netlify.app |
| @@ -18,6 +18,10 @@ class RcaData(PkModel): | |||
| created_at = Column(db.DateTime, nullable=False, | |||
| default=dt.datetime.utcnow) | |||
|
|
|||
| __table_args__ = ( | |||
| Index('rca_data_query_idx', kpi_id, end_date, data_type), | |||
There was a problem hiding this comment.
This would be more useful as we will always query on kpi_id and data_type first, and then if needed query on end_date
Suggested change
| Index('rca_data_query_idx', kpi_id, end_date, data_type), | |
| Index('rca_data_query_idx', kpi_id, data_type, end_date), |
There was a problem hiding this comment.
I think we come up with this sequence after looking all the queries. Could you confirm the sequence once?
There was a problem hiding this comment.
(RcaData.kpi_id == kpi_id)
& (RcaData.data_type == "line")
& (RcaData.end_date <= end_date)This is the general query we do, replacing data_type with other values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.