forked from taboola/chaos_genius
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dashboard functionality along with some fixes #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add the model for the dashboard * feat: add the dashboard view and controllers * feat: Add new controller functions for dashbaord Added key value pairs in `as_dict` and `safe_dict` methods in Dashboard and DashboardKpiMapper Models Added new controller functions to retrieve dashboard info and to create new dashboard * feat: Create API endpoints for dashboard Created API end points for: 1. Creating new dashboard (/create_new_dashboard) 2. Fetching dashboard corresponding to given dashboard_id (/get_dashboard) 3. Deleting dashboard corresponding to given dashboard_id (/delete_dashboard) 4. Fetching all active dashboard list (/get_dashboard_list) * feat: Add Edit Dashboard API Endpoint Added new API Endpoint for editing/updating the dashboard, this handles change of dashboard name, adding new kpis to the dashboard and removing kpis from the dashboard Refactored the create dashboard API endpoint to use edit_dashboard_kpis controller function internally. Added another column called 'active' to the DashboardKpiMapper class. * refactor: Use Args for input in get_dashboard and delete_dashboard Changed the input method from json to Args for get_dashboard and delete_dashboard APIs Fixed minor bugs in the get_dashboard controller helper functions. * fix: fix bug in edit dashboard API Added missing '()' in edit dashboard API * fix: Add code to handle case where dashboard with given id does not exist Added Handlers for the case when there exist no Dashboards corresponding to the given ID Minor Bug fix in in fetching DashbaordKpiMapper objects Removed 'active' attribute from 'safe_dict' property of DashboardKpiMapper. Used 'safe_dict' for response. * fix: set dashboard_dict to empty dictionary when dashboard does not exist, this is being done in the get_dashboard function * fix: Handle additon of existing but disabled kpis in Dashboard Added code to set active to True in the existing object, when previously disabled kpis are requested to be added again instead of creating a new object. * fix: change function which checks if given the KPI's exist in the dashboard. * Changed check_kpis_in_dashboard in dashboard_controller.py to check if the provided list of KPIs is a subset of the KPIs present in the dashboard * fix: added missing ',' in chaos_genius/app.py * fix: respond with empty list when fetch error in get_dashboard_list Set dashboard_list to empty list in the except block of get_dashboard_list API. * fix: Make only active Dashboards Accessible Made changes in dashboard controller functions so that only active dashboards are retreived and passed on to the APIs. * feat: add migration files for dashboard and dashboard_kpi_manager * fix: merge dashboard and task table migration * Removed migration for unwanted table "data upload" * Added new migration file for merging dashboard and task table * fix: change API Endpoint names Changed API Endpoint names to: - `/dashboard/create` - `/dashboard/edit` - `/dashboard/get` - `/dashboard/delete` - `/dashboard/list` Removed id from DashbaordKpiMapper's safe_dict property. * feat:make changes in GET request of /api/kpi - send dashboard name and dashboard id with response object - in the response object dashboards are present under "dashboards" key - dashboards are sent in the form of dictionary where key is dashboard id and value is dashboard name * fix: change edit dashbaord implementation Changed edit_dashboard_kpis controller function to compare the new kpi list with list of existing active kpis in the dashboard and perform addition and deletion accordingly. Changed the usage of edit_dashboard_kpis function in create and edit dashboard endpoints. * feat: make changes to POST request of /api/kpi - create dashboard_kpi_mappers for dashboard id's sent along with request object while adding a new KPI * fix: insert comma while importing views from chaos_genius.views * fix: reabase dashboard migration on top of migration in base branch Deleted redundant migration files Made new migration from the dashbaord and dashbaord kpi mapper tables which revises the head migration present in dashbaord-feature branch Co-authored-by: Manas Solanki <manassolanki@gmail.com> Co-authored-by: RamneekKaur983 <ramneek983@gmail.com> Co-authored-by: Kshitij Agarwal <kshitij123456aga@gmail.com>
* fix: dashboard ui * fix: new kpi home screen * fix: kpi home dropdown and css fixes * fix: dashboard filter in kpi * fix: route fix * fix: removed unused code * fix: removed unused code * fix: minor css * fix: dashboard card css fixes * dashboard list api integrations * fix: dashboard delete redux setup * fix: add edit dashboard ui * fix: create dashboard redux setup * fix:kpi select option kpi list added * fix: add dashboard functional * fix: edit dashboard redux setup * fix: edit dashboard integrations * fix: attach params in url * fix:search functionality dashboard * fix:redux setup for update dashboard * fix: removed mandatory option for dimension in kpi * fix: dashboard api integrations * fix: deepdrill drilldown empty state * fix: server error empty state * fix:edit dashboard url change * fix: create dashboard toaster integration * fix: servererror removed * fix: revert kpi dimension * fix: update dashboard toaster * fix: delete dashboard toaster * fix: removed empty screen * fix:onboarding screen fixed * fix: onboarding dashboard toaster and popup * fix: removed console warnings * fix: onboarding fixes * fix:card clickable * fix: route configuration fix * fix: env url fix * fix: loader issue fixed * onboarding dashboard popup issue fixed * fix:remove unused coded * fix: dashboard more option fix * fix: kpi table filter * fix: kpi table css fixes * fix: dashboard screen for onboarding * fix: dashboard name in table fixed * fix: minor changes * fix: kpi form dashboard popup dropdown fix * kpi table filter scrollbar css fixes * fix: onboarding dashboard revert * fix: home sidebar api integrations * fix: dashboard option * fix: kpi form dashboard api integrations * fix: filter clickable * dashboard popup api integration * fix: dashboard field issues fixed * fix: dashboard name validation in kpi form * modal popup css fix * fix: dashboard option reset dataset table change * fix: home sort functionality * fix:kpi form validations * fix: minor changes * fix:kpi form payload format * fix:sidebar disabled removed and dashboard Api end point changed * fix:table dashboard column name added * fix: kpi table filter * fix: sidebar css fixes * fix:minor fixes * fix:dashboard form and table refactor issues fixed * fix:minor fixes * fix: filter refactor fixes * fix:table column refactor fixed * fix:filter logic fixed * fix: dashboard filter fixes * fix: filter clickable issue fixed * fix:datasource issues fixed * fix: dashboardname search in kpiexplorer * fix:dashboard sidebar active issues fixed * fix: kpi home filter * fix:home kpi dashboard feature * fix:resolve conflicts in images and routes changes * fix:error screen and minor changes * fix: remove commented code Co-authored-by: santhosh kumar <santhosh@sketchbrama.com>
Fix breadcrumbs
* fix:dashboard sorting functionality and replace text * fix:sort text added * fix:removed unused code Co-authored-by: santhosh kumar <santhosh@sketchbrama.com>
… KPI Home Card Clickable (#509) * fix: kpi name tooltip added * fix: kpi table css fixes * fix:dashboard card lastmodified changes * fix: table tooltip fix * fix:table names tooltip added * fix: table,dashboard card,kpi home elipsis fixes * fix: kpi home filter tooltip * fix: dashboard filter tooltip * fix: kpi filter tooltip * dashboard card tooltip css fixes * fix:setting page tooltip * fix:card clickable * fix: tooltip color fixes * fix:sidebar width changes * fix: css fixes * removed commanded code * removed env variables Co-authored-by: Moghan Kumar <moghan@sketchbrahma.com> Co-authored-by: santhosh kumar <santhosh@sketchbrama.com>
* fix:dashboard limited functionality * fix: added storage-helper Co-authored-by: santhosh kumar <santhosh@sketchbrama.com>
✔️ Deploy Preview for frontend-sb ready! 🔨 Explore the source changes: e8a9196 🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/61c2e5eef09a00000706d9cd 😎 Browse the preview: https://deploy-preview-520--frontend-sb.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.