fix(alerts): remove subtraction of 1 day in anomaly end date #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed because the last date of data in DB was different from the anomaly end date, since the data loader using `< end_date` for query. This behaviour was changed in #661 to use `<= end_date`. Now, the subtraction is unnecessary and causes alerts to be sent for one day older anomalies too.
|
✔️ Deploy Preview for frontend-sb ready! 🔨 Explore the source changes: 4d450b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/6203662727aacc00083cfb2e 😎 Browse the preview: https://deploy-preview-680--frontend-sb.netlify.app |
|
Tested this locally - the issues we noticed before does not occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677
This was needed because the last date of data in DB was different from
the anomaly end date, since the data loader using
< end_dateforquery.
This behaviour was changed in #661 to use
<= end_date. Now, thesubtraction is unnecessary and causes alerts to be sent for one day
older anomalies too.