fix(scheduler): remove microsecond component from scheduled_time #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #830 This ensures that `scheduled_time` is always lesser than `last_scheduled_time_rca` if the date, hour, minute and second match exactly. This prevents DeepDrills/Anomaly from being scheduled again if the microsecond component happens to be greater when all other components match. Tested this on 15 KPIs - none of them displayed the bug. Co-authored-by: Rajdeep Sharma <rjdp9736@gmail.com>
|
✅ Deploy Preview for frontend-sb canceled. 🔨 Explore the source changes: fe82a5f 🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/62386407ee97b8000827cc0e |
|
@Samyak2 Can we include this in v0.5.1? |
|
Yes, this has been tested thoroughly in an internal instance. Test cases to prevent this issue in the future can be added in a separate PR. Edit: daily anomaly and DD were not tested. Would be better to include in v0.6.0. |
rjdp
approved these changes
Mar 30, 2022
|
Tests will be updated in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830
Changes
This ensures that
scheduled_timeis always lesser thanlast_scheduled_time_rcaif the date, hour, minute and second match exactly. This prevents DeepDrills/Anomaly from being scheduled again if the microsecond component happens to be greater when all other components match.Tested this on 15 KPIs - none of them displayed the bug.