Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopsutil-v2.20.5+incompatible causes bugs #2388

Closed
Hexilee opened this issue Oct 13, 2021 · 3 comments · Fixed by #2681
Closed

gopsutil-v2.20.5+incompatible causes bugs #2388

Hexilee opened this issue Oct 13, 2021 · 3 comments · Fixed by #2681
Assignees
@Hexilee
Labels
type/bug Something isn't working
Projects
Project Kanban

Comments

@Hexilee
Copy link
Member

Hexilee commented Oct 13, 2021

Bug Report

Currently, the dependency of gopsutil-v2.20.5+incompatible results in the building fails on Apple M1. We can upgrade gopsutil to v3.x.x to fix this bug.

Another bug we met is the unstable create time of process. Two results of *Process.CreateTime() may be different by 1s error, I guess it's caused by float calculating. It caused a bug in chaos-daemon/bpm, and we fixed it by caching the result of *Process.CreateTime(). I cannot find relevant bug-fix in the release notes of gopsutil, upgrading may be ineffective.
@Hexilee Hexilee self-assigned this Oct 13, 2021
@Hexilee
Copy link
Member Author

Hexilee commented Oct 13, 2021

I will upgrade gopsutil to v3.x.x after #2243 merged.

@Hexilee Hexilee added the type/bug Something isn't working label Oct 13, 2021
@Hexilee Hexilee added this to To do in Project Kanban via automation Oct 13, 2021
@cwen0
Copy link
Member

cwen0 commented Dec 20, 2021 •
edited

@Hexilee I will create a single PR to upgrade gopsutil. Because I need to run unit test on my Mac.

@cwen0 cwen0 mentioned this issue Dec 20, 2021
Merged
9 tasks
@YangKeao
Copy link
Member

For the second problem, I have submitted a fix shirou/gopsutil#1204

Project Kanban automation moved this from To do to Done Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hexilee Hexilee

Labels
type/bug Something isn't working
Projects
Project Kanban
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade gopsutil pkg to v3 cwen0/chaos-mesh
3 participants
@YangKeao @cwen0 @Hexilee