Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove china mainland docker registry mirror in install.sh #2740

Closed
STRRL opened this issue Dec 31, 2021 · 4 comments · Fixed by #2797
Closed

remove china mainland docker registry mirror in install.sh #2740

STRRL opened this issue Dec 31, 2021 · 4 comments · Fixed by #2797

Comments

@STRRL
Copy link
Member

STRRL commented Dec 31, 2021

Feature Request

Request:

Remove docker_mirror feature and related codes in install.sh.

Reason:

  • dockerhub.azk8s.cn( also gcr.azk8s.cn and quay.azk8s.cn) could not access with public network anymore, related issue install.sh --docker-mirror not work #2294
  • After release-2.1, we moved docker images from dockerhub to ghcr.io, there are no other docker registry mirror(s) supporting ghcr.io in china mainland right now.
@rksharma95
Copy link
Contributor

rksharma95 commented Jan 16, 2022

I am new to this project and would like to work on this issue, I checked install.sh we can easily remove it from the FLAGS but at places, it is the part of a conditional statement @STRRL can you help to understand the issue and code dependency well.

@STRRL
Copy link
Member Author

STRRL commented Jan 17, 2022

Hi @rksharma95 I think we could just remove all the codes about docker_mirror directly. If some conditional statement using it, just remove it.

@STRRL
Copy link
Member Author

STRRL commented Jan 17, 2022

/assign @rksharma95

@rksharma95
Copy link
Contributor

Hi @rksharma95 I think we could just remove all the codes about docker_mirror directly. If some conditional statement using it, just remove it.

thanks, I started working on it will submit a PR after I complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants