Fix restart transient with variable time step #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great job, I've got nothing to say expect for .prm formating.
Edit : It seems to be working for CHNS cases, though the residual is not exactly the same (~0.1% of error) after checkpointing and before, but the timestep is the correct one. Same problem as Helene pointed I think
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive/generator.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive/generator.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive/generator.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/taylor-green-vortex-restart-bdf1-adaptive/generator.prm
Outdated
Show resolved
Hide resolved
Comment on lines
+170
to
+172
|
|
||
| // Fix time step to be the last time_step that was used | ||
| time_step = time_step_vector[0]; |
There was a problem hiding this comment.
It is crazy how one line can fix this problem so easily
hepap
approved these changes
Apr 16, 2024
…1-adaptive/generator.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive/generator.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive/generator.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive/generator.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive/generator.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
…1-adaptive.prm Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation
Comments