Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heat flux postprocessor material_id processing #988

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

AmishgaAlphonius
Copy link
Collaborator

@AmishgaAlphonius AmishgaAlphonius commented Jan 21, 2024

Description of the problem

  • In the previous implementation of the heat flux postprocessor, there was a confusion related to the material_id of a cell. As a cell's material_id is defined in the mesh, fluids moving from a cell to another did not have the right material_id when outputted. Futhermore, some dealii meshs have an intrinc way of numbering material_ids (e.g. colorized subdivided_hyper_rectangle) that were leading to inadequate comparison of the material_ids.

Description of the solution

  • As of this PR, in the heat flux postprocessor, the material_id is only used to indentify cell material when solids are present. When simulating with fluids and solids, cells of the mesh in which the fluids lie should have a material_id of 0.
  • For fluids-only simulations, at the moment, their heat fluxes will be output on the entire domain, as the current DataPostprocessor can only hold 1 dof_handler. During postprocessing, the user could clip the domain of interest of each fluid using the phase or filtered_phase fields outputted.

How Has This Been Tested?

  • Visual inspection of outputted results for a:

  • single fluid simulation,

  • 1 fluid + 1 solid simulation, and

  • 2 fluids simulaiton.

Future changes

  • For multiple-fluids simulations, a DataPostprocessor handling multiple dof_handlers to allow postprocessing of quantities of interest of fluids in their respective subdomains will have to be added to the code.

@AmishgaAlphonius AmishgaAlphonius added Quick fix Ready for review Post-processing Modifications to the post-processing module labels Jan 21, 2024
@AmishgaAlphonius AmishgaAlphonius self-assigned this Jan 21, 2024
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you :)!

@blaisb blaisb merged commit ea4aeae into master Jan 22, 2024
15 checks passed
@blaisb blaisb deleted the fix-heat-flux-postprocessor branch January 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post-processing Modifications to the post-processing module Quick fix Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants