convert more tests to use the sharness framework #103
Conversation
Problem: gitignore files are out of date and do not include TAP test products. Update gitignores.
Problem: --retry-connect=N sleeps too long if the first connect doesn't succeed, causing tests to take longer than necessary. Instead of sleeping 1s bewteen connects, sleep 0.1s. Update test.
|
I've got some more sharness conversion stuff pending so I'll just tack it on here. |
garlick
force-pushed
the
sharness_conv2
branch
from
c1f3eb5
to
dbf406b
Compare
| test_expect_success 'telemetry has expected size' ' | ||
| test $(stat -c%s tel2.out) -eq 1926 | ||
| ' |
There was a problem hiding this comment.
i think this approach is fine, but maybe a comment that says generally what is expected of the output? Since to the uniniated, they got no idea what this test does and what "spew" does. Maybe something like
send> on
abcdefghfdfdfadsfdsafdsafdsfsda .... (X times)
recv> ...
on: ...
off: ...
| @@ -0,0 +1,114 @@ | |||
| #!/bin/sh | |||
|
|
|||
| test_description='Test Powerman status query' | |||
There was a problem hiding this comment.
not necessarily for this PR, but do you need to cover the "pm -q foo[1-3]" case too? Get all status and then filter it down? TBH, I didn't even know about the -Q option, I always do pm -q foo[1-3] :-)
There was a problem hiding this comment.
Yeah might as well!
I'm getting reacquainted with the project too. The tests before were super inscrutable and now they at least tell you kind of what they are doing and can be more easily grouped functionally.
| test_expect_success 'powerman -r t1 works' ' | ||
| $powerman -h $testaddr -r t1 >reset1.out && | ||
| echo "Command completed successfully" >reset1.exp && | ||
| test_cmp reset1.exp reset1.out | ||
| ' | ||
| test_expect_success 'powerman -r t[3-5] works' ' | ||
| $powerman -h $testaddr -r t[3-5] >reset2.out && | ||
| echo "Command completed successfully" >reset2.exp && | ||
| test_cmp reset2.exp reset2.out | ||
| ' |
There was a problem hiding this comment.
not ncessarily for this PR as you're just converting old tests, but should we be checking on/off before and after doing these?
There was a problem hiding this comment.
No reset doesn't affect on/off. It's an optional hardware reset (like press the reset button).
Problem: tests/t06, tests/t07, and tests/t12 cover powerman status query using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: tests/t08, t09, t10, t17, and t18 cover powerman telemetry output using the old test infrastructure. Convert to sharness. Be lazy and just check the output size rather than check that the content exactly matches like the old test. I think this fulfills the goal of the test. Remove the old test scripts and data.
Problem: Problem: tests/t11 covers powerman on/off/cycle operations using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: tests/t14 covers powerman temperature query using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: tests/t13 covers powerman beacon control using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: tests/t15 covers powerman reset control using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: the list of tests in test/README is out of date. Remove the tests that have been converted to sharness thus far.
garlick
force-pushed
the
sharness_conv2
branch
from
dbf406b
to
79a8268
Compare
|
Thanks! I pushed those fixes and will set MWP. |
Just moving some more tests into sharness.
Also: gitignore updated, and recently added
--reconnect-retrydelay adjusted to avoid excessive waiting.