Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add retain-handle flag in disk fill experiment #26

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Apr 14, 2020

Signed-off-by: xcaspar x.caspar@gmail.com

Describe what this PR does / why we need it

chaosblade-io/chaosblade#325

Does this pull request fix one issue?

Describe how you did it

Add retain-handle flag to hold the file handle.

Describe how to verify it

blade c disk fill --retain-handle --percent 50

Use lsof command to lookup file handle:

 lsof | grep chaos_filldisk.log.dat
chaos_fil 26833          root    3r      REG              253,1 6320816128         18 /chaos_filldisk.log.dat
chaos_fil 26833 26834    root    3r      REG              253,1 6320816128         18 /chaos_filldisk.log.dat
chaos_fil 26833 26835    root    3r      REG              253,1 6320816128         18 /chaos_filldisk.log.dat
chaos_fil 26833 26836    root    3r      REG              253,1 6320816128         18 /chaos_filldisk.log.dat
chaos_fil 26833 26838    root    3r      REG              253,1 6320816128         18 /chaos_filldisk.log.dat

Special notes for reviews

Signed-off-by: xcaspar <x.caspar@gmail.com>
@xcaspar xcaspar added the type/enhancement New feature or request label Apr 14, 2020
@xcaspar xcaspar added this to the v0.6.0 milestone Apr 14, 2020
@RinaisSuper RinaisSuper merged commit a06d8ee into master Apr 14, 2020
@xcaspar xcaspar deleted the feature-chaosblade-325 branch December 2, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
2 participants