Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize hard code issue about version number in docker executor #331

Closed
xcaspar opened this issue Apr 15, 2020 · 0 comments
Closed

Optimize hard code issue about version number in docker executor #331

xcaspar opened this issue Apr 15, 2020 · 0 comments
Labels
chaosblade-exec-docker chaosblade-exec-docker project type/enhancement New feature or request
Projects
ChaosBlade for General
Milestone
v0.6.0

Comments

@xcaspar
Copy link
Member

xcaspar commented Apr 15, 2020

Issue Description

Type: feature request

Describe what happened (or what feature you want)

When upgrading the version number, we must manually modify the following code:

// TODO hard code
var defaultBladeTarFilePath = fmt.Sprintf("/opt/chaosblade-%s.tar.gz", "0.5.0")

Describe what you expected to happen

Specify the version number at compile time.

Tell us your environment

Anything else we need to know?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chaosblade-exec-docker chaosblade-exec-docker project type/enhancement New feature or request
Projects
ChaosBlade for General
Published
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@xcaspar