feature: support to specify chaosblade version for docker experiments #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xcaspar <x.caspar@gmail.com>
xcaspar
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 10.31% 10.31%
=======================================
Files 23 23
Lines 1241 1241
=======================================
Hits 128 128
Misses 1100 1100
Partials 13 13 Continue to review full report at Codecov.
|
RinaisSuper
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xcaspar x.caspar@gmail.com
Describe what this PR does / why we need it
#331
Does this pull request fix one issue?
Describe how you did it
Add
-X ${DOCKER_BLADE_VERSION}.BladeVersion=$(BLADE_VERSION)to specify chaosblade version for docker.Describe how to verify it
Create docker experiments to test.
Special notes for reviews