Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify writing of some code and remove some redundant constants #144

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

jievince
Copy link
Contributor

Describe what this PR does / why we need it

  • Modify some code to follow the rule RULE006 - Return fast to indent less
  • Reome some redundant constants to unify the code style

Does this pull request fix one issue?

NONE

@codecov-io
Copy link

Codecov Report

Merging #144 into master will increase coverage by 0.04%.
The diff coverage is 12.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   14.85%   14.89%   +0.04%     
==========================================
  Files          56       56              
  Lines        2781     2773       -8     
==========================================
  Hits          413      413              
+ Misses       2331     2323       -8     
  Partials       37       37
Impacted Files Coverage Δ
exec/os/script_exit.go 0% <0%> (ø) ⬆️
exec/os/network_dns.go 0% <0%> (ø) ⬆️
exec/os/script_delay.go 0% <0%> (ø) ⬆️
exec/os/network_loss.go 0% <0%> (ø) ⬆️
exec/os/cpu.go 14.15% <0%> (+0.13%) ⬆️
exec/os/disk_burn.go 0% <0%> (ø) ⬆️
exec/os/network_drop.go 0% <0%> (ø) ⬆️
exec/os/bin/burncpu/burncpu.go 46.75% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e57aa...86f298e. Read the comment docs.

@xcaspar xcaspar added this to the 0.3.0 milestone Jul 26, 2019
@xcaspar xcaspar merged commit 8716749 into chaosblade-io:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants