add new flag scan external jar package #416
Conversation
cyemars
changed the title
cli/cmd/prepare_jvm.go
Outdated
| pc.command.Flags().StringVarP(&pc.javaHome, "javaHome", "j", "", "the java jdk home path") | ||
| pc.command.Flags().StringVarP(&pc.chaosbaldeJarPath, "chaosbaldeJarPath", "jarPath", "", "the java jdk home path") |
cli/cmd/prepare_jvm.go
Outdated
| @@ -102,14 +105,14 @@ func (pc *PrepareJvmCommand) prepareJvm() error { | |||
| "please append or modify the --port %s argument in prepare command for retry", record.Port)) | |||
| } | |||
| } | |||
| response, username := jvm.Attach(record.Port, pc.javaHome, pc.processId) | |||
| response, username := jvm.Attach(record.Port, pc.javaHome, pc.processId,pc.chaosbaldeJarPath) | |||
exec/jvm/sandbox.go
Outdated
| jvmOpts = fmt.Sprintf("-Xms128M -Xmx128M -Xnoclassgc -ea -Xbootclasspath/a:%s:%s", toolsJar, chaosbaldeJarPath) | ||
| logrus.Printf("chaosblade jvmOpts:%s", jvmOpts) | ||
| } else { | ||
| jvmOpts = fmt.Sprintf("-Xms128M -Xmx128M -Xnoclassgc -ea -Xbootclasspath/a:%s:", toolsJar) |
There was a problem hiding this comment.
An extra colon is written.
You can write in the following way:
jvmOpts = xxxx
if condition {
jvmOpts = fmt.Sprintf("%s:%s", jvmOpts, xxx)
}
panic: "jp" shorthand is more than one ASCII character goroutine 1 [running]: |
cli/cmd/prepare_jvm.go
Outdated
| pc.command.Flags().StringVarP(&pc.javaHome, "javaHome", "j", "", "the java jdk home path") | ||
| pc.command.Flags().StringVarP(&pc.chaosbladeJarPath, "jarPath", "jp", "", "the java jdk home path") |
There was a problem hiding this comment.
"jp" shorthand is more than one ASCII character
|
@cyemars This scheme seems not to work. -Xbootclasspath is only started for the JVM that loads the agent, not the JVM that affects the application |
Describe what this PR does / why we need it
解决Java工程无法调用外部jar 包
Does this pull request fix one issue?
添加flag 指定外部jar 包扫描路径
Describe how you did it
在agent挂载的时候传入jar包路径 扫描二方包