Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig & cpu load test params #8

Merged
merged 4 commits into from Mar 30, 2019
Merged

Add .editorconfig & cpu load test params #8

merged 4 commits into from Mar 30, 2019

Conversation

wooramel
Copy link

No description provided.

@wooramel
Copy link
Author

usage: blade create cpu fullload --timeout 5 (in seconds)

@xcaspar
Copy link
Member

xcaspar commented Mar 28, 2019

usage: blade create cpu fullload --timeout 5 (in seconds)

Great, this feature is exactly what we want to add, can you open an issue to associate this pr?

@xcaspar xcaspar added the type/enhancement New feature or request label Mar 28, 2019
@wooramel
Copy link
Author

#9

@xcaspar
Copy link
Member

xcaspar commented Mar 29, 2019

#9

Thank you for submitting the issue and pr. I have two questions here:

  • The feature adapts the host to fail to respond the chaosblade tool invoked again, such as network blocking, memory leaks, and can we extract it to the upper layer as a generic capability?

  • Direct stop process cannot change the status of the experiment, can we stop and modify the experiment status, similar to executing the destroy command?

@wooramel
Copy link
Author

updated :^p

@wooramel
Copy link
Author

By the way, add new feature --cpu-num param

@xcaspar xcaspar merged commit 7607148 into chaosblade-io:master Mar 30, 2019
@xcaspar
Copy link
Member

xcaspar commented Mar 30, 2019

By the way, add new feature --cpu-num param

Awesome. Thank you again. Welcome you to join the project :-)

@xcaspar xcaspar added the type/feature Category issues or prs related to feature request. label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request type/feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants