Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Modify code to enhance readability #27

Merged
merged 5 commits into from Aug 8, 2021
Merged

Modify code to enhance readability #27

merged 5 commits into from Aug 8, 2021

Conversation

yash-yp
Copy link
Member

@yash-yp yash-yp commented Aug 8, 2021

Changes:

  • Give meaningful names to checks in translations_release.py
  • Added docstrings to functions
  • Replaced github in variable names with repo
    • github-link -> repo-link
    • github-branch -> repo-branch

Signed-off-by: Yash Prakash <yash2002109@gmail.com>
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

automation-english/helper.py Outdated Show resolved Hide resolved
automation-english/helper.py Outdated Show resolved Hide resolved
ritik-malik and others added 2 commits August 8, 2021 20:16
Co-authored-by: Georg J.P. Link <linkgeorg@gmail.com>
Signed-off-by: maalik <ritik18406@iiitd.ac.in>

Co-authored-by: Georg J.P. Link <linkgeorg@gmail.com>
Copy link
Member

@ritik-malik ritik-malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yash2002109 ,
and thanks @GeorgLink for your suggestions

@ritik-malik ritik-malik merged commit f0fa568 into main Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants