fixing augurface #1087
Merged
fixing augurface #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix looks good to me, but now I'm realizing that the config does not get written to the |
|
@ccarterlandis : Per our discussion last night, I think keeping the frontend.config.json in one place makes it easier. This PR accomplishes that goal. |
|
@ccarterlandis : Do you know why the Docker tests are not running? |
sgoggins
added a commit
that referenced
this pull request
Jan 27, 2021
Merge pull request #1087 from chaoss/augurface-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to the configuration file
frontend.config.jsonwas incorrect, and while the variableconfigwas set insrc/store/UtilModule.js, the variableconfigObjectwas required.PR also includes audit fixes from NPM.