Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to contributor resolution #1508

Merged
merged 14 commits into from
Oct 30, 2021
Merged

Updates to contributor resolution #1508

merged 14 commits into from
Oct 30, 2021

Conversation

sgoggins
Copy link
Member

Addressing a bug caused by Github user 'NaN', who is interpreted as a float instead of as a string without explicit type casting.

sgoggins and others added 11 commits October 21, 2021 17:40
Solving this one:
2021-10-28 17:56:31,879,879ms [PID: 2982487] workers.github_worker.57714 [DEBUG] Enriching 11572 contributors.
2021-10-28 17:56:31,879,879ms [PID: 2982487] workers.github_worker.57714 [INFO] nan not in database, making api call
2021-10-28 17:56:31,879,879ms [PID: 2982487] workers.github_worker.57714 [INFO] login: nan
2021-10-28 17:56:31,879,879ms [PID: 2982487] workers.github_worker.57714 [INFO] Error when creating url: can only concatenate str (not "float") to str. Data: {'id': 2046382478, 'issue_id': 36162, 'node_id': 'MDE0Ok1lbnRpb25lZEV2ZW50MjA0NjM4MjQ3OA==', 'url': 'https://api.github.com/repos/chaoss/augur/issues/events/2046382478', 'actor': {}, 'created_at': Timestamp('2018-12-27 20:09:55'), 'event': 'mentioned', 'commit_id': None, 'actor.login': nan, 'actor.id': nan, 'actor.node_id': nan, 'actor.avatar_url': nan, 'actor.gravatar_id': nan, 'actor.url': nan, 'actor.html_url': nan, 'actor.followers_url': nan, 'actor.following_url': nan, 'actor.gists_url': nan, 'actor.starred_url': nan, 'actor.subscriptions_url': nan, 'actor.organizations_url': nan, 'actor.repos_url': nan, 'actor.events_url': nan, 'actor.received_events_url': nan, 'actor.type': nan, 'actor.site_admin': nan}
…Hub user NaN, who is interpreted as a float.
Copy link
Member Author

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I expected.

@sgoggins sgoggins added bug Documents unexpected/wrong/buggy behavior bug-fix Fixes a bug server Related to the Augur server labels Oct 29, 2021
@sgoggins sgoggins merged commit 853bc8f into main Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Documents unexpected/wrong/buggy behavior bug-fix Fixes a bug server Related to the Augur server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant