Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to worker_base.py #1575

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Small change to worker_base.py #1575

merged 1 commit into from
Jan 25, 2022

Conversation

ABrain7710
Copy link
Contributor

  1. Made a small change to an if else block which makes it more readable

The old version had two chains of if else blocks using python's syntax, which I found very difficult to read, so I changed it to 1 more traditional if else block

Essentially I took 2 if else chains using python syntax to 1 more traditional if else block

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Copy link
Contributor

@IsaacMilarky IsaacMilarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems better and more readable for sure. I don't know why there was some unnecessary redundancy before.

@sgoggins sgoggins merged commit 64b3a84 into main Jan 25, 2022
@ABrain7710 ABrain7710 deleted the andrew-worker-base branch January 27, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants