Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker git integration refactor #1602

Merged
merged 114 commits into from
Feb 2, 2022
Merged

Worker git integration refactor #1602

merged 114 commits into from
Feb 2, 2022

Conversation

IsaacMilarky
Copy link
Contributor 

I reworked parts of my contributor interface for the facade worker to be more in line with the methods in worker_git_integration.py. Also I cleaned up worker_git_integration.py a bit in general.

ABrain7710 and others added 30 commits October 15, 2021 12:06
@ABrain7710
Set up basic structure for worker_persistance tests
2dcb319 
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@IsaacMilarky
Merge branch 'docker_test_data' into test-worker-persistance
9f3e983
@IsaacMilarky
Up to date database container
3ef55eb 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Docker fixture written out
4f0f41f 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
More fixtures for sample data
82feb50 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
filename change
32bd59b 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
More progress
e7d2be2 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Kind of a hack but so long as it works
2c6d317 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Oh it was a typo
ca3fac5 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Remove import
9ec43c1 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
build string typo
fdfc589 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
python scripting
7599d79 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Debug
446efc6 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
syntax
0aca00f 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
typo
1e5283f 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
change default port
f72efcd 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
change default port
ab983a0 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
syntax
24d5d99 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
no bash nonsenese
b6bfc14 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
five seconds
67bd4af 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Updated paths
283af33 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
syntax
750ed16 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
test
5127368 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
No detach
7978f19 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
figuring out how to deploy database without too much overhead
b3cbcef 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
syntax
ecefe5c 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Progress
8ed499c 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Debugging
b045709 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Debugging
59eacc2 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Doing insertion with right fields this time
11a3eb2 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Fix merge conflicts
9f7d277 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
merge
7b8d251 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
trying to fix weird git merge errors
03f94b9 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Use existing method instead of my own for more readability
abf25a8 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Syntax
adb3c9a 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
syntax
ed0315b 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Set default finishing_task for contributor_interface to False since T…
7637032 
…rue functionality is technically deprecated? Also move method only used by pr worker to the pr worker class

Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Delete duplicate method definition in worker_git_integration \'update…
0435ea4 
…_gitlab_rate_limit\'

Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Some cleanup of worker_git_integration.py
cbd2b95 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Revert to use of query_github_contributors
5799f81 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
comment
c2a9583 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Put more generic methods of contributor interface into worker_git_int…
883353e 
…egration

Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
continue added to avoid using unreferenced variable
4fcb932 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Log debug
25c94be 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Merge main into current branch
7357497 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
multi_thread_urls only needed in pull request worker
eaca993 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Typo. 'self' where it should have been s
7720506 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Syntax error in db execute statement in query_github_contributors
ab0f423 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Print traceback when exception triggered
3e7a7ac 
Signed-off-by: Isaac M <krabs@tilde.team>
@IsaacMilarky
Set worker type contributor interface
584b5dc 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
Interface using query_github_contributors
a2bc8c1 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky
typo
40614b1 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@sgoggins sgoggins closed this Feb 2, 2022
@sgoggins sgoggins reopened this Feb 2, 2022
@sgoggins sgoggins changed the base branch from test to facade-test February 2, 2022 19:41
@sgoggins sgoggins merged commit a456e02 into facade-test Feb 2, 2022
sgoggins
sgoggins reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to try it!

sgoggins
sgoggins reviewed Feb 3, 2022
View reviewed changes
workers/worker_git_integration.py
)
elif platform == 'github':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaacMilarky :This might not work the same way as the current version. Its something I'll look for in the logs during testing.

@sgoggins sgoggins deleted the worker_git_integration_refactor branch March 11, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IsaacMilarky @sgoggins @ABrain7710