Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization Error Delivery #1617

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Conversation

ABrain7710
Copy link
Contributor

  1. Added check on start_date and end_date for visualizations. If the end_date is before the start_date, it will respond with an error.
  2. With the increasing number of errors being caught, I moved the error checking to the get_repo_id_start_date_and_end_date() method, which sends an error object back if an error occurs. Then the endpoint code checks if there is an error object. If there is, it gets the message and status code from the error object and sends them to the user.

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@sgoggins sgoggins merged commit 0948e34 into main Feb 14, 2022
@ABrain7710 ABrain7710 deleted the clean-up-visualization-error-delivery branch June 24, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants