Fix error that happens if legacy migration fail in the schema script #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Whenever there was an error in the legacy SQL files, alembic would register that the alembic revision 0 was not completed since it errored out in the middle. While the SQL files were getting COMMITED periodically. Therefore alembic thought that nothing had been done to the database and started at the beginning, when in fact all the SQL files up to the error had already been COMMITED to the database. Therefore whenever someone tried to run the database install after it failed once on the legacy files, it would error saying that the schema already exists.
Fix: I removed all the COMMIT statements in the SQL files, and added one file called commit.sql that gets executed at the end of the legacy SQL files. Therefore if all the legacy SQL files succeed then the database reflects that, but if any of them fail, then no changes are made to the database