Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Fixes to Augur New #2012

Merged
merged 7 commits into from Oct 25, 2022
Merged

Miscellaneous Fixes to Augur New #2012

merged 7 commits into from Oct 25, 2022

Conversation

ABrain7710
Copy link
Contributor

@ABrain7710 ABrain7710 commented Oct 20, 2022

Description

  1. Changed the cli options for augur config init to use dashes in the option names rather than underscores
  2. Added a logger to the RandomKeyAuth class, so it can log when there are no valid keys. Before it was erroring because someone tried to log this statement using self.error()
  3. Fixes the regex expressions in the repo load controller to allow for .github and .github.io repos

This PR fixes

  1. Error when deleting users. The API to delete a user now deletes all the users repos in the user_repos table before deleting the user from the users table.
  2. Fixed the user/update API. Now it returns missing argument if either user or password is None, rather than only when user is None. It also checks to make sure an email or username isn't already taken when updating them. It also returns missing argument now if only the username and password are returned. Lastly, I removed an unneeded else since the API returned inside of the if clause.

Signed commits

  • Yes, I signed my commits.

Andrew and others added 7 commits October 13, 2022 15:04
Signed-off-by: Andrew <andrew@root@chaoss.tv>
Signed-off-by: Sean Goggins <outdoors@acm.org>
Signed-off-by: Andrew <andrew@root@chaoss.tv>
Signed-off-by: Andrew <andrew@root@chaoss.tv>
Signed-off-by: Andrew <andrew@root@chaoss.tv>
Signed-off-by: Andrew <andrew@root@chaoss.tv>
@ABrain7710 ABrain7710 marked this pull request as ready for review October 20, 2022 20:15
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins merged commit ec83262 into augur-new Oct 25, 2022
@ABrain7710 ABrain7710 deleted the augur-new-small-fixes branch October 27, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants