Hardcode bash #2119
Merged
Hardcode bash #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Scherer <misc@redhat.com>
mscherer
force-pushed
the
hardcode_bash
branch
from
865a877
to
9a961f6
Compare
|
@IsaacMilarky : Can you take a look at this one and let me know if you need an EC2 to experiment. |
|
@IsaacMilarky : Can you look at this one as well? |
IsaacMilarky
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that for a reason I can't understand (and to be fair, I am not that motivated to go deeply in that rabbit hole), the shebang do not work on podman. Removing /usr/bin/env make it work fine, and since there is almost no reason to see bash move anywhere out of /usr, I think that's safe to just remove env and directly use bash.
Notes for Reviewers
Signed commits