New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade collection update #2184
Facade collection update #2184
Conversation
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…y removed except for their use in determining the status of whether a repo was cloned Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@IsaacMilarky : Does this make sense for me to test first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused with some of the changes. I thought we were going to have only the facade_status
since the repo_status
is only relating to Facade so it isn't really a repo_status
. I'm now just confused as to why we need both. Couldn't we just have a facade_status
that has values of ("Pending", "Update", "Failed Clone", "Success", "Errored")? I thought this is what we came to the other day.
@@ -0,0 +1,101 @@ | |||
"""change CollectionStatus table to keep track of facade independently | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IsaacMilarky This should only include, the changes that are needed for this pr. I can change this if you would like
You're right I'll make those changes. I think I just had forgotten that when I was making the clean_collection_status method since that resets the collection status of interrupted tasks to pending and from that I forgot to remove the repo_status field since that keeps track of the status of the git repo |
…redundant Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few small changes, then tested it and it appears to be working as expected. I will note that with these changes it is important to set the collection_interval
to a smaller value since the secondary data won't be collected until the primary data finishes, and the next augur_collection_monitor
task runs again.
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…is 300 times the collection interval which is a minute by default Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…to facade-collection-update
Description
Signed commits