Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Optimization to Github Events Task #2206

Merged
merged 1 commit into from Feb 28, 2023
Merged

Conversation

ABrain7710
Copy link
Contributor

Description

  • The processing of events now only makes 1 query to the db rather than 1 query per event.
  • When collecting 300 pages (max github will return) of events it took 268 second with the new changes, and 303 seconds with dev. So a 35 second improvement, with far less queries to the database.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@sgoggins sgoggins merged commit 9e7aaf9 into dev Feb 28, 2023
@ABrain7710 ABrain7710 deleted the gh-events-optimization branch March 6, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants